From 0c2db9d85af55e36f2043070860d02058a452733 Mon Sep 17 00:00:00 2001 From: clad2 Date: Wed, 5 Aug 2026 17:27:17 +0000 Subject: [PATCH] test(labels): remove the stale never-silenced check, superseded behaviourally MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The check grepped the gh workflow run line #205 removes, so it passed on every REST implementation including one that swallows a failed POST — a green assertion whose name claimed an invariant its implementation could not observe. Its replacement lives in test/labels-dispatch.test.sh: a transport failure must fail the extracted step, plus a code-aware no-|| true guard (@codex-reviewer-andresmgsl, !213 review round 2). Refs #205 --- test/labels-triggers.test.sh | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/test/labels-triggers.test.sh b/test/labels-triggers.test.sh index c941e67..14847c5 100644 --- a/test/labels-triggers.test.sh +++ b/test/labels-triggers.test.sh @@ -81,9 +81,13 @@ check "the trigger dispatches the sweep caller by name" 0 \ grep -F '/dispatches' "$REUSABLE" check "...never bootstrapping" 0 'bootstrap: "no"' \ grep -F 'bootstrap' "$REUSABLE" -# shellcheck disable=SC2016 # $1 expands in the nested bash, not here -check "the trigger dispatch is never silenced with || true" 1 "" \ - bash -c 'grep -F "gh workflow run" "$1" | grep -qF "|| true"' _ "$REUSABLE" +# The never-silenced invariant moved to test/labels-dispatch.test.sh, where it +# is BEHAVIOURAL: a curl that dies at the transport must fail the extracted +# step, plus a code-aware no-`|| true` guard on the step itself. The check that +# lived here grepped the `gh workflow run` line #205 removed, so after the port +# it passed on every implementation including one that swallows a failed POST — +# a green assertion whose name claimed an invariant its implementation could +# not observe (@codex-reviewer-andresmgsl, #213 review). check "the sweep caller filename input defaults to labels-sweep.yml" 0 \ "default: labels-sweep.yml" grep -F 'default: labels-sweep.yml' "$REUSABLE" # the dogfood callers wear the split: the event caller names its deviant