codex-bot-andresmgsl/rig
1
0
Fork 0
forked from heavy-duty/rig
Code Pull requests Activity

fix: the guard's comment misstated set -e, and the form now matches its twins

Browse source
This commit is contained in:
dan-claude-bot 2026-07-21 17:12:54 +00:00
parent dbe04c7c36
commit 186d976686
1 changed files with 22 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
.github/scripts/drill-recorded.sh vendored
View file

@ -100,16 +100,28 @@ record="$drills/$version.md"
# tab shipped an evidence-free release. `grep -q '[^[:space:]]'` is the whole # tab shipped an evidence-free release. `grep -q '[^[:space:]]'` is the whole
# check now, with no extractor in front of it to get wrong. # check now, with no extractor in front of it to get wrong.
# #
# Written as if/then, NOT as `[ -f "$record" ] && recorded=yes`. Under `set -e` # The negated form below, matching box's and cast's twins exactly, so there is
# a bare `a && b` statement whose last command fails takes the whole script # no divergence between the three to explain.
# down with its exit status — so a miss would exit 1 here, before the failure #
# message below ever printed, and the author would see nothing. # It also avoids a real `set -e` hazard, which is worth naming precisely
recorded=no # because an earlier draft of this comment named it BACKWARDS. A bare
if [ -f "$record" ] && grep -q '[^[:space:]]' "$record"; then # `[ -f "$record" ] && grep -q ... "$record"` mid-script does NOT abort when
recorded=yes # the file is missing: the left-hand side of `&&` is exempt from errexit, so a
fi # miss simply continues. What DOES abort is the other case — the file exists
# and `grep` finds nothing, i.e. exactly the whitespace-only record this guard
if [ "$recorded" != yes ]; then # is here to refuse. The script would die on its most interesting input,
# before printing the message that explains it.
#
# Verified rather than reasoned about:
# bash -ec '[ -f /nonexistent ] && r=yes; echo reached' -> prints, exit 0
# bash -ec 'f=$(mktemp); echo " " >"$f"
# [ -f "$f" ] && grep -q "[^[:space:]]" "$f"
# echo reached' -> silent, exit 1
#
# Caught by all three reviewers on #104. The lesson is the same one #149 and
# cast#138 taught: this family's comments get read as contracts, so a comment
# that misstates the semantics is a defect even when the code is correct.
if [ ! -f "$record" ] || ! grep -q '[^[:space:]]' "$record"; then
{ {
echo "drill-recorded: VERSION is $version, and there is no drill record at $record." echo "drill-recorded: VERSION is $version, and there is no drill record at $record."
echo echo