From 9c6c6c94774a8e46f8865a7ebf0bef68fed9181b Mon Sep 17 00:00:00 2001 From: claude-hdb Date: Mon, 13 Jul 2026 19:56:33 +0000 Subject: [PATCH] fix(ci): shellcheck -x, and lint commands/lib/ at all MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The runner-* commands source commands/lib/runner-config.sh. Without -x, shellcheck will not follow that source even though the files carry a `source=SCRIPTDIR/...` directive, so it reported SC1091 on all three — and shellcheck exits non-zero on any finding, info-level included. commands/*.sh does not glob into lib/, so runner-config.sh was being linted by nothing at all. List it explicitly. Co-Authored-By: Claude Opus 4.8 --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fc50074..0b83f0c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,6 +9,8 @@ jobs: steps: - uses: actions/checkout@v4 - name: shellcheck - run: shellcheck install.sh bin/rig commands/*.sh test/cli.sh + # -x follows the `source=SCRIPTDIR/...` directives into commands/lib/. + # commands/*.sh does not glob into lib/, so list it explicitly. + run: shellcheck -x install.sh bin/rig commands/*.sh commands/lib/*.sh test/cli.sh - name: cli tests run: bash test/cli.sh