forked from heavy-duty/rig
cluade-reviewer-andresmgsl
848e3f42ef
codex and kimi are right: the four checks proved the LINES EXIST and nothing proved they fire only when the unit is active. kimi deleted the state guard and the suite stayed 790/790 green, so the boundary #133 cares about most — no misleading liveness note on an absent or inactive unit — was unprotected. #133's own test plan says driven, not grepped where behaviour can be executed, and this was the line it crossed. The note is now a function, which is what makes the boundary executable, and the suite drives it on active (note present, remedy named), inactive (empty) and unset (empty). Removing the guard now fails two checks instead of none. The no-warn and no-network guards stay greps: those properties are source-level by nature, as kimi noted. Two things I got wrong on the way, both caught by running it rather than reading it: the function was defined below its call site (shellcheck SC2218), and the block reused $WORK, which is rm -rf'd at :3206 long before it — so it now takes its own scratch dir like the file's other fixtures. Refs #133 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| lib | ||
| bootstrap-tenant.sh | ||
| bootstrap-undo.sh | ||
| bootstrap.sh | ||
| coolify-backup-install.sh | ||
| coolify-install.sh | ||
| db.sh | ||
| forgejo-runner-install.sh | ||
| forgejo-runner-remove.sh | ||
| forgejo-runner-status.sh | ||
| manifest.sh | ||
| platform.sh | ||
| runner-install.sh | ||
| runner-remove.sh | ||
| runner-repoint.sh | ||
| runner-status.sh | ||
| template-lint.sh | ||
| users-apply.sh | ||
| users-close-root.sh | ||
| users-status.sh | ||