From fcb7ce3b7d29aa10bffe2539f6c433662d84c127 Mon Sep 17 00:00:00 2001 From: dan-claude-bot Date: Sun, 19 Jul 2026 15:42:06 +0000 Subject: [PATCH] =?UTF-8?q?fix:=20a=20-dev=20endstate=20is=20always=20work?= =?UTF-8?q?=20=E2=80=94=20the=20post-release=20bump=20must=20not=20run=20r?= =?UTF-8?q?ed?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The four-state table called '-dev but changed' half a ceremony and refused — but that state IS the mandatory post-release bump PR (bare -> X.Y.(Z+1)-dev after every release), a red run on main once per release, forever. A tree that ends -dev is by definition not a release: every such merge is work, green NOTICE no-op. Red now guards only bare endstates. Co-Authored-By: Claude Fable 5 --- .github/workflows/release.yml | 11 +++++++---- test/release.test.ts | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 6f12c37..fe4e1ee 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -75,8 +75,10 @@ jobs: # trigger included. The version tells them apart, in four states: # -dev, unchanged → work under the label: green NOTICE # no-op, not a red run per infra PR - # -dev, changed → a bump that forgot to leave -dev: - # half a ceremony, refuse + # -dev, changed → still a dev tree, so still work — + # the post-release bump PR above all + # (bare -> -dev after every release): + # green NOTICE no-op # bare, unchanged, released → work merged in the post-release # window (ceremony landed, the -dev # bump has not — and cast's ENTIRE @@ -109,8 +111,9 @@ jobs: echo "ceremony=no" >> "$GITHUB_OUTPUT" exit 0 fi - echo "version changed ('$base' -> '$ver') but is still -dev — half a ceremony; a release PR ships a bare X.Y.Z (CONTRIBUTING.md, Releasing) — creating nothing." >&2 - exit 1 ;; + echo "NOTICE: version changed ('$base' -> '$ver') and still ends -dev — a dev tree is by definition not a release. This is work (the post-release bump, a renumber); nothing to publish." + echo "ceremony=no" >> "$GITHUB_OUTPUT" + exit 0 ;; esac if [ "$base" = "$ver" ]; then if gh release view "$ver" > /dev/null 2>&1; then diff --git a/test/release.test.ts b/test/release.test.ts index 33a4820..7b0297e 100644 --- a/test/release.test.ts +++ b/test/release.test.ts @@ -205,7 +205,7 @@ describe("release.yml", () => { // Code-unique phrasings (the workflow's own comment table paraphrases // these states, so the pins anchor on the echo strings, not prose): "release-flow work under the release label, not a ceremony. Nothing to publish.", // work no-op, green - "— half a ceremony; a release PR ships a bare X.Y.Z", // -dev but changed: refuse + "a dev tree is by definition not a release", // -dev endstate: always work (the bump PR no-ops green) "release-flow work merged in the post-release window (before the -dev bump)", // window no-op "Refusing to guess — creating nothing.", // bare, unchanged, unreleased: refuse ".github/scripts/release-notes.sh", // assert: notes extract