From 2b49d6ef59e1d7f745d520fab4047cc5fee656f5 Mon Sep 17 00:00:00 2001 From: cluade-reviewer-andresmgsl Date: Thu, 6 Aug 2026 11:33:42 +0000 Subject: [PATCH] fix(labels): the panel names an identity that can actually review (#222) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit kimi-reviewer-andresmgsl is temporarily unavailable, and with a three-identity panel it sits in the required set for every possible author — so no new PR could converge while it is down. glm-reviewer-andresmgsl takes the seat. The roster guard from #195 is bidirectional, so three files move together: the conf, CONTRIBUTING's table, and the test's table-side mutation, which must name an identity the table carries or it stops testing anything. Refs #222 --- .github/labels.conf | 2 +- CONTRIBUTING.md | 2 +- changelog.d/222.md | 10 ++++++++++ test/labels.test.sh | 2 +- 4 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 changelog.d/222.md diff --git a/.github/labels.conf b/.github/labels.conf index 405dcbc..1e24bbe 100644 --- a/.github/labels.conf +++ b/.github/labels.conf @@ -1,4 +1,4 @@ -panel=codex-reviewer-andresmgsl kimi-reviewer-andresmgsl cluade-reviewer-andresmgsl +panel=codex-reviewer-andresmgsl glm-reviewer-andresmgsl cluade-reviewer-andresmgsl triage-actors=cluade-reviewer-andresmgsl scope:release-flow|C5DEF5|The reusable release workflow, decide, the doors scope:guards|C5DEF5|changelog-armed / changelog-monotonic / drill-recorded diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 39d38ca..c5e3c2d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -50,7 +50,7 @@ the box is the blast-radius boundary; roles are what a session is told, and |---|---|---| | `cluade-reviewer-andresmgsl` | `triage` (claude-box) | **triage** — the only door issues come through; this identity mints issues and nothing else writes them (#18's `triage-actors`) — and review. It does not build. | | `codex-reviewer-andresmgsl` | codex-box | build + review | -| `kimi-reviewer-andresmgsl` | kimi-box | review | +| `glm-reviewer-andresmgsl` | glm-box | review | **The review panel for any PR is every bench identity except its author** — recusal by construction, enforced by the reconciler (#10): the required diff --git a/changelog.d/222.md b/changelog.d/222.md new file mode 100644 index 0000000..6fdf537 --- /dev/null +++ b/changelog.d/222.md @@ -0,0 +1,10 @@ +### Changed + +- The review panel names `glm-reviewer-andresmgsl` in place of + `kimi-reviewer-andresmgsl` while that identity is unavailable. The panel + stays three, so a PR still requires two cross-vendor approvals (#222). + +- `test/labels.test.sh`'s table-side roster mutation names an identity the + table actually carries. Naming a departed one would mutate nothing and the + case would pass while proving nothing — #195's rot class one layer down + (#222). diff --git a/test/labels.test.sh b/test/labels.test.sh index 8e08297..72a8297 100755 --- a/test/labels.test.sh +++ b/test/labels.test.sh @@ -246,7 +246,7 @@ sed 's/^panel=/panel=ghost-bot /' "$CONF" >"$mut_conf" check "an identity in the conf but not the table goes red" 1 "ghost-bot" \ roster_in_sync "$mut_conf" "$CONTRIB" # shellcheck disable=SC2016 # the backticks are the table's, not a subshell -sed 's/^| `kimi-reviewer-andresmgsl`/| `ghost-bot`/' "$CONTRIB" >"$mut_contrib" +sed 's/^| `glm-reviewer-andresmgsl`/| `ghost-bot`/' "$CONTRIB" >"$mut_contrib" check "an identity in the table but not the conf goes red" 1 "ghost-bot" \ roster_in_sync "$CONF" "$mut_contrib"