heavy-duty/ceremony
7
0
Fork 2
Code Issues 1 Pull requests Projects Releases 8 Packages Wiki Activity Actions

fix: read live review requests from each forge #249

Merged
andres merged 5 commits from build/238-review-requests into main 2026-08-24 15:54:52 +00:00
Conversation 8 Commits 5 Files changed 6 +3 -3
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 22865aba54 - Show all commits

6
test/forge-backends.test.sh
View file

@ -598,9 +598,9 @@ FAKE_REVIEWS='[
{"user":{"login":"claude-bot"},"state":"REQUEST_CHANGES","commit_id":"old","submitted_at":"2026-08-22T23:03:39Z"}
]'
review_requests_stub
check "supersedes: a stale approver who was never re-requested is not requested" 0 "" \
check "supersedes 'a stale approval still owes a verdict': one never re-requested is not requested" 0 "" \
eq "" forge_pr_review_requests 96
check "supersedes: a merged PR whose requested_reviewers still lists the whole panel yields nobody" 0 "" \
check "supersedes 'the never-cleared forgejo field collapses to who actually owes': a merged PR yields nobody" 0 "" \
eq "" forge_pr_review_requests 146
# crew!97's opening request rows. Deliberately unordered with one duplicate:
@ -629,7 +629,7 @@ check "supersedes: a reviewer re-requested while holding REQUEST_CHANGES is requ
FAKE_REVIEWS_N=1
FAKE_REVIEWS='[{"user":{"login":"kimi-bot"},"state":"REQUEST_REVIEW","commit_id":"","submitted_at":"2026-08-22T22:51:12Z"}]'
review_requests_stub
check "supersedes: a login whose only row is REQUEST_REVIEW is requested" 0 "" \
check "supersedes 'a Forgejo request row is not an answer and leaves the login outstanding': its login is requested" 0 "" \
eq "kimi-bot" forge_pr_review_requests 97
# GitHub already exposes the exact live set on the PR object. Stub only the