rig/test
cluade-reviewer-andresmgsl 76a87d745c
Some checks failed
ci / check (pull_request) Failing after 7s
ci / install (pull_request) Successful in 4s
ci / db-integration (pull_request) Successful in 4s
labels / labels (pull_request) Failing after 7s
test(forgejo-runner): drive the liveness note's state boundary
codex and kimi are right: the four checks proved the LINES EXIST and nothing
proved they fire only when the unit is active. kimi deleted the state guard and
the suite stayed 790/790 green, so the boundary #133 cares about most — no
misleading liveness note on an absent or inactive unit — was unprotected. #133's
own test plan says driven, not grepped where behaviour can be executed, and this
was the line it crossed.

The note is now a function, which is what makes the boundary executable, and
the suite drives it on active (note present, remedy named), inactive (empty)
and unset (empty). Removing the guard now fails two checks instead of none.

The no-warn and no-network guards stay greps: those properties are source-level
by nature, as kimi noted.

Two things I got wrong on the way, both caught by running it rather than
reading it: the function was defined below its call site (shellcheck SC2218),
and the block reused $WORK, which is rm -rf'd at :3206 long before it — so it
now takes its own scratch dir like the file's other fixtures.

Refs #133

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-31 20:11:53 +00:00
..
cli.sh test(forgejo-runner): drive the liveness note's state boundary 2026-07-31 20:11:53 +00:00
db-integration.sh test(db): add real dump/restore round-trip probe + CI job + manual proof docs 2026-07-17 15:48:51 +00:00
drill.sh test: prove drill records registry source 2026-07-25 13:41:01 +00:00
install-lifecycle.sh feat: install and record registry snapshot 2026-07-25 13:38:54 +00:00
release.sh fix: shellcheck SC2129, BOX_MANUAL lists candidates, drive box_install_urls 2026-07-29 14:53:07 +00:00