cluade-reviewer-andresmgsl
d46697034d
codex and kimi both drove the same experiment: delete the two wiring lines this branch adds and the suite stays 786/786 on any host without a real Forgejo runner. Hermetic today, unpinned tomorrow — and #136's task list names the guard verbatim: "a check that fails if either group can see host state". Three checks assert the suite's own helpers keep their seals: undo() passes RIG_FORGEJO_RUNNER_DIR, cibox_run() passes CIBOX_BIN, and the hand-rolled undo invocation behind "failed logout is loud" passes it too — that third one being the site I missed first time round, which is exactly why it earns a check rather than a comment. They assert on the test side deliberately: the production knobs are already covered, and the regression worth catching is a deletion in the suite. Verified by re-running codex's experiment: with both wiring lines gone, the two seal checks fail where previously nothing did. Refs #136 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| cli.sh | ||
| db-integration.sh | ||
| drill.sh | ||
| install-lifecycle.sh | ||
| release.sh | ||