forked from heavy-duty/ceremony
cluade-reviewer-andresmgsl
9db8317543
Found by running ceremony's own CI at 9357f09 on a real Forgejo runner
rather than reasoning about it.
`label` is a reserved word in jq's grammar (`label $out | … | break $out`),
so jq **1.6** rejects `$label` outright:
jq: error: syntax error, unexpected label, expecting IDENT
jq 1.7 parses it, which is why this survived: GitHub's hosted ubuntu-latest
ships 1.7, and ghcr.io/catthehacker/ubuntu:act-22.04 — the image this
instance maps ubuntu-latest to — ships 1.6. So parse_labeler_config died on
a compile error before it read a byte of config, and EVERY scope derivation
on this forge failed. Renamed to $lbl in the jq program only; the bash
locals keep their names.
Also makes test/forge.test.sh hermetic. Its "github + gh passes" case
depended on gh being on the HOST's PATH, so it passed on a developer box and
failed in the runner image, which has no gh. The preflight cases now run
against stub binaries, and the missing-binary refusal gets its own arm on a
PATH carrying the shell and text tools but no clients — the condition under
test, rather than whatever the machine happens to have.
Verified in both environments: local (jq 1.7, gh present) and the runner
image (jq 1.6, no gh) — shellcheck 0, 22 files 0 failed in each.
Refs #188
45 lines
2.2 KiB
Markdown
45 lines
2.2 KiB
Markdown
### Added
|
|
|
|
- `lib/forge.sh` — the forge selector: `forge_detect` names the forge from
|
|
the runner's own environment, `forge_client` names the client it needs, and
|
|
`forge_preflight` refuses loudly before any sweep when the two disagree
|
|
(#188).
|
|
- The reconcilers and `labels-scope` run that preflight first, so a
|
|
GitHub-shaped client on a Forgejo instance is a named refusal instead of a
|
|
sweep that reads nothing and reports success (#188).
|
|
- `lib/closes_references.sh` — the closing-keyword parser, sibling of
|
|
`refs_references`, so "which issues does this PR close" is answered from a
|
|
PR body rather than from GitHub's GraphQL API (#188).
|
|
- `lib/forge-github.sh` and `lib/forge-forgejo.sh` — one call surface, two
|
|
backends, selected by `forge_select`; no forge branching at the call sites
|
|
(#188).
|
|
- The forgejo backend proves each paginated gather complete against the
|
|
server's `x-total-count` and refuses loudly when it cannot — a missing
|
|
header is a refusal, not a pass (#188).
|
|
|
|
### Changed
|
|
|
|
- `issueflow-reconcile` gathers open and merged PRs over REST instead of
|
|
`gh api graphql`. Forgejo serves no GraphQL at all, so the two queries were
|
|
replaced rather than translated; both forges return `number` and `body`
|
|
from `/pulls` in the same shape (#188).
|
|
|
|
- `forge_api` owns the page size, because each forge silently ignores the
|
|
other's parameter: `per_page=100` reads 30 items on Forgejo and `limit=100`
|
|
reads 30 on GitHub, both HTTP 200. No call site names one (#188).
|
|
|
|
- Outstanding review requests are derived from the reviews on the current head
|
|
rather than from `requested_reviewers`, which Forgejo never clears — read
|
|
raw there, a PR would sit at `state:bots-reviewing` forever (#188).
|
|
|
|
### Fixed
|
|
|
|
- `labels-scope` no longer fails to compile its jq program on jq 1.6, which
|
|
the Forgejo runner image ships: `label` is a reserved word in jq's grammar,
|
|
so `$label` is a syntax error there and every scope derivation died before
|
|
reading the config (#188).
|
|
|
|
- `labels-reconcile` and `labels-scope` no longer exit 0 on a Forgejo
|
|
consumer having read zero facts — measured on `heavy-duty/rig`, where the
|
|
sweep printed `reconciled.` over an empty PR list and scope reported "no
|
|
labeler.yml" for a file that exists (#188).
|