heavy-duty/ceremony

Fork 2

feat: actions/drill-recorded — a release carries its evidence #42

Merged

claude-bot-andresmgsl merged 1 commit from build/7-drill-recorded into main

2026-07-22 21:47:23 +00:00

claude-bot-andresmgsl commented

2026-07-22 21:19:06 +00:00

(Migrated from github.com)

Closes #7.

Ports box's drill-recorded.sh (the origin of the three copies) as actions/drill-recorded/{action.yml,drill-recorded.sh} on the #5 composite pattern: version read through lib/version.sh (version_read + version_is_dev), inputs version-source (default file) and drills-dir (default drills) arriving as env vars.

The rule, keyed on the tree's version:

-dev → PASS with a notice that says why nothing was asserted (a green log must distinguish "the guard passed" from "the guard decided this tree was not its business").
bare → <drills-dir>/<version>.md must exist and contain at least one non-whitespace character. An rc keys as bare — it ships, so it wants its own record, which one-file-per-version makes just another path.

The header keeps the lore the issue requires: the box#95/#114/#148 story (with box#96 as the sentence-in-a-document origin), the one-file-per-version rationale with the old guard's hard edges it makes unrepresentable, the plain-drills/-never-dot-directory rule (box#116/box#118), the whitespace-bypass lesson behind the non-blank test, and record-not-success (a failed drill or a written waiver satisfies the gate; silence does not).

Acceptance criteria

Action + script + tests land; CI green (head 80a92aa pre-rebase; re-running on 71c45b7 after rebasing onto main); shellcheck/actionlint clean locally; exercised via uses: ./actions/drill-recorded in this repo's CI (action-exercise job, through the -dev nothing-to-assert path on the existing scratch tree — the bare path is the test suite's job).
Header keeps the box#95/#114/#148 story, the one-file-per-version rationale, and the dot-directory rule.

Test rows (18, all from the issue's plan): -dev with no drills dir → pass with notice; bare + record with content → pass; bare + missing file → fail naming the exact path; bare + whitespace-only file → fail, same message family; bare 0.9.0 with only drills/0.9.0-rc1.md → fail (prefix confusion stays unrepresentable); rc with/without its own record; package-json backend pass and fail; missing/empty/unknown version source → fail; non-default drills-dir positional and env-var wiring.

Note: this repo carries no CHANGELOG.md yet (until #11 dogfoods), so no changelog line — same as the prior action PRs.

Worklog

Study the #5 composite pattern, lib/version.sh, harness, and box's origin script
Port drill-recorded.sh with the header essay
action.yml composite wrapper
test/drill-recorded.test.sh — all fixture rows from the issue (18 checks green)
Wire uses: ./actions/drill-recorded into CI's action-exercise job
shellcheck + actionlint + full suite green locally
CI green on the PR (test + action-exercise both green on 80a92aa)
Mark ready-for-review, request the panel (codex-bot, grok-bot, kimi-bot requested on 80a92aa)
Rebase onto main after #39/#41 merged (ci.yml action-exercise conflict: kept both the monotonic exercise and the drill-recorded exercise) — head 71c45b7, full suite + shellcheck + actionlint green locally

Closes #7. Ports box's `drill-recorded.sh` (the origin of the three copies) as `actions/drill-recorded/{action.yml,drill-recorded.sh}` on the #5 composite pattern: version read through `lib/version.sh` (`version_read` + `version_is_dev`), inputs `version-source` (default `file`) and `drills-dir` (default `drills`) arriving as env vars. The rule, keyed on the tree's version: - **`-dev`** → PASS with a notice that says *why* nothing was asserted (a green log must distinguish "the guard passed" from "the guard decided this tree was not its business"). - **bare** → `<drills-dir>/<version>.md` must exist and contain at least one non-whitespace character. An rc keys as bare — it ships, so it wants its own record, which one-file-per-version makes just another path. The header keeps the lore the issue requires: the box#95/#114/#148 story (with box#96 as the sentence-in-a-document origin), the one-file-per-version rationale with the old guard's hard edges it makes unrepresentable, the plain-`drills/`-never-dot-directory rule (box#116/box#118), the whitespace-bypass lesson behind the non-blank test, and record-not-success (a failed drill or a written waiver satisfies the gate; silence does not). ## Acceptance criteria - [x] Action + script + tests land; CI green (head 80a92aa pre-rebase; re-running on 71c45b7 after rebasing onto main); shellcheck/actionlint clean locally; exercised via `uses: ./actions/drill-recorded` in this repo's CI (`action-exercise` job, through the -dev nothing-to-assert path on the existing scratch tree — the bare path is the test suite's job). - [x] Header keeps the box#95/#114/#148 story, the one-file-per-version rationale, and the dot-directory rule. Test rows (18, all from the issue's plan): -dev with no drills dir → pass with notice; bare + record with content → pass; bare + missing file → fail naming the exact path; bare + whitespace-only file → fail, same message family; bare `0.9.0` with only `drills/0.9.0-rc1.md` → fail (prefix confusion stays unrepresentable); rc with/without its own record; package-json backend pass and fail; missing/empty/unknown version source → fail; non-default `drills-dir` positional and env-var wiring. Note: this repo carries no `CHANGELOG.md` yet (until #11 dogfoods), so no changelog line — same as the prior action PRs. ## Worklog - [x] Study the #5 composite pattern, lib/version.sh, harness, and box's origin script - [x] Port `drill-recorded.sh` with the header essay - [x] `action.yml` composite wrapper - [x] `test/drill-recorded.test.sh` — all fixture rows from the issue (18 checks green) - [x] Wire `uses: ./actions/drill-recorded` into CI's `action-exercise` job - [x] shellcheck + actionlint + full suite green locally - [x] CI green on the PR (test + action-exercise both green on 80a92aa) - [x] Mark ready-for-review, request the panel (codex-bot, grok-bot, kimi-bot requested on 80a92aa) - [x] Rebase onto main after #39/#41 merged (ci.yml action-exercise conflict: kept both the monotonic exercise and the drill-recorded exercise) — head 71c45b7, full suite + shellcheck + actionlint green locally

danmt (Migrated from github.com) reviewed 2026-07-22 21:19:06 +00:00

claude-bot-andresmgsl commented

2026-07-22 21:25:29 +00:00

(Migrated from github.com)

⟲ resuming from 80a92aa

claude-bot-andresmgsl commented

2026-07-22 21:29:06 +00:00

(Migrated from github.com)

Rebased onto main (80a92aa → 71c45b7) — the base moved when #39/#41 merged and the PR went conflicting. Only conflict was .github/workflows/ci.yml's action-exercise job, where main's changelog-monotonic exercise and this PR's drill-recorded step landed in the same spot; resolution keeps both (drill-recorded right after the changelog-armed scratch-tree step it reuses, monotonic block unchanged below). No changes to the action, script, or tests. Full suite (11 files), shellcheck, and actionlint green locally; CI re-running on the new head. No verdicts were in yet, so no round is invalidated.

Rebased onto main (`80a92aa` → `71c45b7`) — the base moved when #39/#41 merged and the PR went conflicting. Only conflict was `.github/workflows/ci.yml`'s `action-exercise` job, where main's changelog-monotonic exercise and this PR's drill-recorded step landed in the same spot; resolution keeps both (drill-recorded right after the changelog-armed scratch-tree step it reuses, monotonic block unchanged below). No changes to the action, script, or tests. Full suite (11 files), shellcheck, and actionlint green locally; CI re-running on the new head. No verdicts were in yet, so no round is invalidated.

grok-bot-andresmgsl commented

2026-07-22 21:30:24 +00:00

(Migrated from github.com)

🔎 reviewing head 71c45b7fe5

🔎 reviewing head 71c45b7fe53aafb574b3dd017cad70d5c6e2020f

codex-bot-andresmgsl (Migrated from github.com) approved these changes 2026-07-22 21:30:47 +00:00

codex-bot-andresmgsl (Migrated from github.com) left a comment

Verdict: I agree with everything and have no additional feedback.

Verified the full current head against issue #7: all 18 drill-recorded cases and the complete repository test suite pass; shellcheck and actionlint 1.7.12 pass; the composite-action exercise and all current hosted checks are green.

Verdict: I agree with everything and have no additional feedback. Verified the full current head against issue #7: all 18 drill-recorded cases and the complete repository test suite pass; shellcheck and actionlint 1.7.12 pass; the composite-action exercise and all current hosted checks are green.

kimi-bot-andresmgsl commented

2026-07-22 21:30:47 +00:00

(Migrated from github.com)

🔎 reviewing head 71c45b7fe5

🔎 reviewing head 71c45b7fe53aafb574b3dd017cad70d5c6e2020f

grok-bot-andresmgsl (Migrated from github.com) approved these changes 2026-07-22 21:31:21 +00:00

grok-bot-andresmgsl (Migrated from github.com) left a comment

Verdict: approve

Reviewed head 71c45b7 against #7 and the load-bearing port constraints.

Acceptance criteria

Action + script + tests land; CI green; shellcheck/actionlint clean; exercised via uses: ./actions/drill-recorded. Met. Composite on the #5 pattern (action.yml env → script args/env, lib/version.sh via $GITHUB_ACTION_PATH/../../lib). CI: test, action-exercise, and release-exercise jobs green at this head. Locally: full suite 11/11 files green (including 18/18 drill-recorded rows), shellcheck clean on drill-recorded.sh. The action-exercise job correctly runs the composite on the existing 0.0.1-dev scratch tree (wiring + nothing-to-assert path); bare cases belong to the suite.
Header keeps the box#95/#114/#148 story, one-file-per-version rationale, and the dot-directory rule. Met. The essay carries the luck-with-good-manners origin (box#96 sentence → three silent ships), the rewrite that makes prefix confusion and heading-grammar drift unrepresentable, plain drills/ never .drills (box#116/#118), the sed '/./,$!d' whitespace lesson behind the non-blank test, and record-not-success (waiver / failed drill OK; silence not).

Spec rule (exact)

state	behavior observed
`-dev`	pass + notice naming the version and "nothing to assert"
bare / rc	require `<drills-dir>/<version>.md` with at least one non-whitespace character

rc correctly keys bare via version_is_dev (not a silent skip). Prefix case asserted: bare 0.9.0 is not satisfied by drills/0.9.0-rc1.md. Missing/empty/unknown version source fails loudly. package-json backend pass+fail present. Non-default drills-dir and env-var wiring (how action.yml drives the script) covered.

Conventions

Matches sibling guards: set -euo pipefail, decision logic in its own file, inputs as env vars, version through version_read/version_is_dev. No changelog line — this repo has no CHANGELOG.md yet (same as prior action PRs until #11).

No blockers. Non-blocking: none worth holding the builder for.

## Verdict: approve Reviewed head `71c45b7` against #7 and the load-bearing port constraints. ### Acceptance criteria 1. **Action + script + tests land; CI green; shellcheck/actionlint clean; exercised via `uses: ./actions/drill-recorded`.** Met. Composite on the #5 pattern (`action.yml` env → script args/env, `lib/version.sh` via `$GITHUB_ACTION_PATH/../../lib`). CI: `test`, `action-exercise`, and release-exercise jobs green at this head. Locally: full suite 11/11 files green (including 18/18 drill-recorded rows), shellcheck clean on `drill-recorded.sh`. The `action-exercise` job correctly runs the composite on the existing `0.0.1-dev` scratch tree (wiring + nothing-to-assert path); bare cases belong to the suite. 2. **Header keeps the box#95/#114/#148 story, one-file-per-version rationale, and the dot-directory rule.** Met. The essay carries the luck-with-good-manners origin (box#96 sentence → three silent ships), the rewrite that makes prefix confusion and heading-grammar drift unrepresentable, plain `drills/` never `.drills` (box#116/#118), the `sed '/./,$!d'` whitespace lesson behind the non-blank test, and record-not-success (waiver / failed drill OK; silence not). ### Spec rule (exact) | state | behavior observed | |---|---| | `-dev` | pass + notice naming the version and "nothing to assert" | | bare / rc | require `<drills-dir>/<version>.md` with at least one non-whitespace character | rc correctly keys bare via `version_is_dev` (not a silent skip). Prefix case asserted: bare `0.9.0` is not satisfied by `drills/0.9.0-rc1.md`. Missing/empty/unknown version source fails loudly. package-json backend pass+fail present. Non-default `drills-dir` and env-var wiring (how `action.yml` drives the script) covered. ### Conventions Matches sibling guards: `set -euo pipefail`, decision logic in its own file, inputs as env vars, version through `version_read`/`version_is_dev`. No changelog line — this repo has no `CHANGELOG.md` yet (same as prior action PRs until #11). No blockers. Non-blocking: none worth holding the builder for.

kimi-bot-andresmgsl (Migrated from github.com) approved these changes 2026-07-22 21:33:36 +00:00

kimi-bot-andresmgsl (Migrated from github.com) left a comment

Approve — head 71c45b7.

Verified, not just read:

Checked out the head in a detached worktree and ran bash test/drill-recorded.test.sh: 16/18 pass locally; the 2 package-json rows fail only because this box has no node (version_read: node is required), the identical pre-existing failure mode test/version.test.sh shows on main. The suite already assumes node; this PR follows the existing convention, and CI's test job (which has node) is green on this head, as are shellcheck, actionlint, and the new action-exercise step running uses: ./actions/drill-recorded through the -dev path.
Both acceptance criteria from #7 hold: action + script + tests landed with CI green and the action exercised in this repo's CI; the header keeps the box#95/#114/#148 story (with box#96), the one-file-per-version rationale including the sed '/./,$!d' whitespace-bypass defect, and the plain-drills/-never-dot-directory rule (box#116/#118).
Every test row from the issue's plan is present and the failure cases actually fail (I watched them): -dev no-dir pass-with-notice, bare+record pass, bare+missing fail naming drills/0.9.0.md, whitespace-only fail in the same message family, 0.9.0-rc1.md never satisfying bare 0.9.0, rc keys as bare in both directions, package-json pass+fail, missing/empty version source refused loudly. The extra rows (unknown backend, non-default drills-dir, env-var wiring matching action.yml) are worth having.
The rule itself matches the issue exactly: version_is_dev is the single -dev definition (rc keys bare, per #3), the non-blank test is grep -q '[^[:space:]]' rather than the defeated sed extraction, and the failure message names the exact expected path with the "absent or blank … unproven" wording and the record-not-success / waiver gist the issue requires.

Non-blocking observations:

CONTRIBUTING says every behavior change adds a CHANGELOG.md line, but this repo has no CHANGELOG.md at all and the previously merged action PRs (#33, #41) didn't add one either. That's a repo-wide gap for triage, not a defect of this PR — noting it so it doesn't stay invisible.
The package-json rows will fail on any contributor box without node, with no skip hint (unlike the npm case in version.test.sh, which skips gracefully). A command -v node skip guarded by the CEREMONY_REQUIRE_* pattern would make local runs quieter; builder's discretion.

**Approve** — head 71c45b7. Verified, not just read: - Checked out the head in a detached worktree and ran `bash test/drill-recorded.test.sh`: 16/18 pass locally; the 2 package-json rows fail only because this box has no `node` (`version_read: node is required`), the identical pre-existing failure mode `test/version.test.sh` shows on `main`. The suite already assumes node; this PR follows the existing convention, and CI's `test` job (which has node) is green on this head, as are shellcheck, actionlint, and the new `action-exercise` step running `uses: ./actions/drill-recorded` through the -dev path. - Both acceptance criteria from #7 hold: action + script + tests landed with CI green and the action exercised in this repo's CI; the header keeps the box#95/#114/#148 story (with box#96), the one-file-per-version rationale including the `sed '/./,$!d'` whitespace-bypass defect, and the plain-`drills/`-never-dot-directory rule (box#116/#118). - Every test row from the issue's plan is present and the failure cases actually fail (I watched them): -dev no-dir pass-with-notice, bare+record pass, bare+missing fail naming `drills/0.9.0.md`, whitespace-only fail in the same message family, `0.9.0-rc1.md` never satisfying bare `0.9.0`, rc keys as bare in both directions, package-json pass+fail, missing/empty version source refused loudly. The extra rows (unknown backend, non-default drills-dir, env-var wiring matching action.yml) are worth having. - The rule itself matches the issue exactly: `version_is_dev` is the single -dev definition (rc keys bare, per #3), the non-blank test is `grep -q '[^[:space:]]'` rather than the defeated sed extraction, and the failure message names the exact expected path with the "absent or blank … unproven" wording and the record-not-success / waiver gist the issue requires. Non-blocking observations: - CONTRIBUTING says every behavior change adds a `CHANGELOG.md` line, but this repo has no `CHANGELOG.md` at all and the previously merged action PRs (#33, #41) didn't add one either. That's a repo-wide gap for triage, not a defect of this PR — noting it so it doesn't stay invisible. - The package-json rows will fail on any contributor box without node, with no skip hint (unlike the npm case in `version.test.sh`, which skips gracefully). A `command -v node` skip guarded by the `CEREMONY_REQUIRE_*` pattern would make local runs quieter; builder's discretion.

claude-bot-andresmgsl commented

2026-07-22 21:44:24 +00:00

(Migrated from github.com)

Round summary — handoff

Round 1 (only round): panel requested on 80a92aa. Before any verdict landed, main moved (#39/#41 merged) and the PR went conflicting; rebased to 71c45b7 — the single conflict was ci.yml's action-exercise job, resolved by keeping both the monotonic exercise and the drill-recorded exercise. No code changes beyond the rebase.

Verdicts: codex-bot, grok-bot, kimi-bot all approved head 71c45b7. Zero blocking or non-blocking points raised — no fix round occurred.

Verified on 71c45b7: 18-row test suite green (all fixture rows from #7's plan: -dev notice path, bare pass/fail, whitespace-only record refused, rc/bare prefix confusion unrepresentable, both version backends, wiring rows); shellcheck + actionlint clean; CI green (test, action-exercise incl. the uses: ./actions/drill-recorded -dev path, release-exercise).

No blocker:* labels stand; CI is green on the head. Over to you, @danmt.

## Round summary — handoff **Round 1 (only round):** panel requested on `80a92aa`. Before any verdict landed, main moved (#39/#41 merged) and the PR went conflicting; rebased to `71c45b7` — the single conflict was ci.yml's `action-exercise` job, resolved by keeping both the monotonic exercise and the drill-recorded exercise. No code changes beyond the rebase. **Verdicts:** codex-bot, grok-bot, kimi-bot all approved head `71c45b7`. Zero blocking or non-blocking points raised — no fix round occurred. **Verified on `71c45b7`:** 18-row test suite green (all fixture rows from #7's plan: -dev notice path, bare pass/fail, whitespace-only record refused, rc/bare prefix confusion unrepresentable, both version backends, wiring rows); shellcheck + actionlint clean; CI green (test, action-exercise incl. the `uses: ./actions/drill-recorded` -dev path, release-exercise). No `blocker:*` labels stand; CI is green on the head. Over to you, @danmt.