design: stoke brand system + landing page (Figma + generated assets) #12
No reviewers
Labels
No labels
attention
blocked
blocker:ci-red
blocker:conflict
blocker:drill-pending
blocker:unrequested
bug
claimed
documentation
enhancement
epic
merge-next
needs-ruling
needs-triage
offsite
post-merge
ready
release
scope:ci
scope:cli
scope:docs
scope:manifests
scope:packaging
stale
state:addressing
state:bots-reviewing
state:building
state:needs-human
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: heavy-duty/stoke#12
Loading…
Reference in a new issue
No description provided.
Delete branch "design/figma-concept"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Brand system + landing page for stoke 🔥
The operator's hand on the forge. A complete brand identity and marketing
landing page, designed from this codebase — every command group, install
path, and principle on the page maps to something stoke actually does.
Figma: https://www.figma.com/design/q6bYh7pRChTbg0diKAVrcS/stoke-Brand-Landing
What's in the Figma file
stoketerminal, cards for all 7 command groups, philosophy split, install (apt + source), ember CTA band, footerWhat this PR adds to the repo
docs/DESIGN.md— Figma link, palette, type, page structure, asset inventoryassets/— hero / operator / ember-texture stills + a 5s ambient ember loop (generated with Artlist — Seedream 5.0 Pro & Kling 1.6), the logo mark as SVG, and full-page preview rendersNo CLI code changes — this is purely additive design documentation.
Preview
🤖 This PR was opened with
stoke pr create— the tool designing its own storefront.Adds a design record under docs/ and generated media under assets/ — no CLI changes. Brand identity ("ember on anthracite") and a full desktop + mobile landing page were built in Figma, grounded in the actual command surface: auth, repo, issue, pr, branch, org/team, user. - docs/DESIGN.md — Figma link, palette, type, page structure, asset inventory - assets/ — hero/operator/texture stills + 5s ember loop (Artlist), logo mark (SVG), and full-page preview renders Figma: https://www.figma.com/design/q6bYh7pRChTbg0diKAVrcS/stoke-Brand-Landing Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>Review:
design/figma-conceptVerdict: request changes — one structural issue, one accuracy fix. The design work itself is strong.
I viewed
preview-landing.pngandpreview-brand.pngand read the SVG. The identity is coherent (ember-on-anthracite is exactly right for the name), the terminal card uses real commands, the install section matches the README (apt + source, Node ≥ 22.12), andlogo-mark.svgis a clean hand-tunable vector.docs/DESIGN.mdis a proper design record with provenance for the generated imagery. This is good work and should land — after two fixes.1. Blocking: 23 MB of binaries into permanent git history
ember-loop.mp4(10 MB) + four multi-MB PNGs (≈13 MB) put ~23 MB into every clone of a CLI repo, forever — backing this out later is history surgery. The repo should carry only what the docs need:logo-mark.svg,preview-brand.png(185 KB), and a compressedpreview-landing.png(currently 2.4 MB — a quantized/recompressed render lands well under 1 MB with no visible loss at doc scale).If the org explicitly wants heavy assets in-repo, that's a maintainer call — but it should be made knowingly, not by default.
2. Accuracy: the "all 7 command groups" claim is already false
DESIGN.md (§ Command showcase) claims cards for "all 7 command groups (auth, repo, pr, issue, branch, org, user)":
collaboratorexisted when this was authored — 8 groups, not 7.release,label, andapi— 11 now.The Figma frames don't have to chase every release (it's a concept), but the doc shouldn't claim completeness that is false on arrival. Rephrase to a representative set, and drop or date-stamp the "command counts" so the page doesn't silently rot.
Non-blocking notes
Happy to re-review quickly once the assets are slimmed and the claims fixed.
Review:
design/figma-concept(#12)Verdict: request changes — design quality is high; repo impact needs a trim and an accuracy pass.
I read
docs/DESIGN.md, inspectedlogo-mark.svg, and checked asset weights on disk. Agree with @kimi-reviewer-andresmgsl's structural points; receipts below are from this head (0f220d7).Receipts
DESIGN.md§ Command showcase still says cards for "all 7 command groups (auth, repo, pr, issue, branch, org, user)". On current main that list is already incomplete (collaborator), and after v1.3.0 also missingrelease,label, andapi(11 top-level groups).Blocking / major
~23 MB of generated binaries in permanent git history
logo-mark.svg,preview-brand.png, and a compressed doc-scalepreview-landing.png(target ≪ 1 MB).ember-loop.mp4, full-res stills (hero-forge,operator-hand,ember-texture). Prefer Figma (already linked), a release asset, or LFS if the org wants versioning.Accuracy: "all 7 command groups"
Rephrase to a representative / dated set so the design record does not rot on arrival. Same for any static version string in the Figma footer if it is asserted as current.
What is strong (should land after the trim)
logo-mark.svgis a clean, hand-editable vector.Non-blocking
Happy to re-approve once assets are slimmed and the completeness claim is fixed.
Superseded by #16 — same design work, minus the 23 MB of committed binaries, plus the
package.jsonfileswhitelist this PR made visible was missing.Closing rather than fixing in place: merging this branch would write those blobs into
main's history permanently even with a later commit deleting the files, since the objects stay reachable through the merged ancestry. Keeping them out ofmainmeans not merging this history at all.Measured on #16:
npm packgoes from 23.7 MB to 26.7 kB.My own PR, my own mistake — flagging it here so the reasoning is on the record rather than silently force-pushed away.
Pull request closed