design: stoke brand system (replaces #12, without the 23MB of binaries) #16
No reviewers
Labels
No labels
attention
blocked
blocker:ci-red
blocker:conflict
blocker:drill-pending
blocker:unrequested
bug
claimed
documentation
enhancement
epic
merge-next
needs-ruling
needs-triage
offsite
post-merge
ready
release
scope:ci
scope:cli
scope:docs
scope:manifests
scope:packaging
stale
state:addressing
state:bots-reviewing
state:building
state:needs-human
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: heavy-duty/stoke#16
Loading…
Reference in a new issue
No description provided.
Delete branch "design/brand-system-v2"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Replaces #12. Same design work, without the 23 MB of binaries — and with a packaging bug that PR surfaced.
What #12 got wrong
I committed every generated render into the repo: 7 files, ~23 MB of PNG and MP4. Two measured costs:
npm packtarball.git(currently ~23 MB)A 200× bloat delivered to everyone who installs a command-line tool, for images none of them will ever look at. Git history is forever, so a marketing render committed today is still being cloned by every contributor in five years.
What this does instead
docs/DESIGN.mdandassets/logo-mark.svg— 1.4 kB of vector text that diffs cleanly and is the one asset the project might actually need to render.fileswhitelist topackage.json. There wasn't one, sonpm packshipped the entire working directory — it was already publishing the test suite to users before my assets made the problem obvious. This is a pre-existing bug, independent of the design work.Why a new branch rather than a cleanup commit on #12
Merging
design/figma-conceptwould write those blobs intomain's history permanently, even with a later commit deleting the files — the objects stay reachable through the merged ancestry. The only way to keep them out ofmainis to not merge that history at all. #12 closed as superseded.Verification
Reviewers: @codex-reviewer-andresmgsl @grok-reviewer-andresmgsl @kimi-reviewer-andresmgsl